From a25508e03c9910a59fdbe895c8c88d6c5d7877c8 Mon Sep 17 00:00:00 2001 From: Rudolf Copi Eckelberg <rce16@inf.ufpr.br> Date: Mon, 10 Oct 2016 10:45:44 -0300 Subject: [PATCH] Changed uggly if chain for switch statement --- src/libs/models/simulation.js | 38 +++++++++++++++++++++++------------ 1 file changed, 25 insertions(+), 13 deletions(-) diff --git a/src/libs/models/simulation.js b/src/libs/models/simulation.js index cf6ad41c..7d5df97e 100644 --- a/src/libs/models/simulation.js +++ b/src/libs/models/simulation.js @@ -72,19 +72,31 @@ SimulationSchema.methods.setEnrollments = function (e) { } SimulationSchema.methods.update = function (property, value) { let success = true; - if (property === 'time') { - if (!this.setTime(value)) success = false; - } else if (property === 'location') { - if (!this.setLocation(value)) success = false; - } else if (property === 'failure_rate') { - if (!this.setFailureRate(value)) success = false; - } else if (property === 'goals_care') { - if (!this.setCareGoals(value)) success = false; - } else if (property === 'goals_inclusion') { - if (!this.setInclusionGoals(value)) success = false; - } else if (property === 'enrollments') { - if (!this.setEnrollments(value)) success = false; - } else success = false; + switch(property){ + case 'time': + if (!this.setTime(value)) success = false; + break; + case 'location': + if (!this.setLocation(value)) success = false; + break; + case 'failure_rate': + if (!this.setFailureRate(value)) success = false; + break; + case 'goals_care': + if (!this.setCareGoals(value)) success = false; + break; + case 'goals_inclusion': + if (!this.setInclusionGoals(value)) success = false; + break; + case 'enrollments': + if (!this.setEnrollments(value)) success = false; + break; + case 'name': + this.name = value; + break; + default: + success = false; + } return success; }; -- GitLab