From f42a686ed34e9ac6ec5499b2e7bffde0d17bf387 Mon Sep 17 00:00:00 2001
From: Vytor Calixto <vytorcalixto@gmail.com>
Date: Mon, 20 Feb 2017 09:49:05 -0300
Subject: [PATCH] Padronize response in english
---
src/libs/routes/city.js | 5 +++--
src/libs/routes/enrollment.js | 4 ++--
src/libs/routes/region.js | 4 +++-
src/libs/routes/school.js | 6 +++---
src/libs/routes/state.js | 8 ++++----
src/test/city.js | 16 ++++++++--------
src/test/enrollment.js | 2 +-
src/test/region.js | 12 ++++++------
src/test/school.js | 6 +++---
src/test/state.js | 24 ++++++++++++------------
10 files changed, 45 insertions(+), 42 deletions(-)
diff --git a/src/libs/routes/city.js b/src/libs/routes/city.js
index bc7a41f3..3b03ef9c 100644
--- a/src/libs/routes/city.js
+++ b/src/libs/routes/city.js
@@ -61,8 +61,9 @@ rqf.addField({
// Return all cities
cityApp.get('/', rqf.parse(), rqf.build(), (req, res, next) => {
req.sql.from('municipio')
- .field('municipio.nome')
- .field('municipio.pk_cod_ibge', 'pk_municipio_id');
+ .field('municipio.nome', 'name')
+ .field('municipio.pk_cod_ibge', 'id')
+ .field('municipio.fk_estado_id', 'state_id');
next();
}, query, response('city'));
diff --git a/src/libs/routes/enrollment.js b/src/libs/routes/enrollment.js
index d5704282..5a6f5c79 100644
--- a/src/libs/routes/enrollment.js
+++ b/src/libs/routes/enrollment.js
@@ -28,7 +28,7 @@ enrollmentApp.get('/year_range', (req, res, next) => {
enrollmentApp.get('/location', (req, res, next) => {
req.sql = squel.select()
- .field('pk_localizacao_id', 'location_id')
+ .field('pk_localizacao_id', 'id')
.field('descricao', 'description')
.from('localizacao');
next();
@@ -213,4 +213,4 @@ enrollmentApp.get('/', rqf.parse(), rqf.build(), (req, res, next) => {
next();
}, query, response('enrollment'));
-module.exports = enrollmentApp;
\ No newline at end of file
+module.exports = enrollmentApp;
diff --git a/src/libs/routes/region.js b/src/libs/routes/region.js
index c7f5ec05..f152d899 100644
--- a/src/libs/routes/region.js
+++ b/src/libs/routes/region.js
@@ -45,7 +45,9 @@ rqf.addField({
}, 'search');
regionApp.get('/', rqf.parse(), rqf.build(), (req, res, next) => {
- req.sql.from('regiao');
+ req.sql.from('regiao')
+ .field('pk_regiao_id', 'id')
+ .field('nome', 'name');
next();
}, query, response('region'));
diff --git a/src/libs/routes/school.js b/src/libs/routes/school.js
index 55792f19..6420db5d 100644
--- a/src/libs/routes/school.js
+++ b/src/libs/routes/school.js
@@ -71,10 +71,10 @@ schoolApp.get('/', rqf.parse(), rqf.build(), (req, res, next) => {
});
}
req.sql.from('escola')
- .field('escola.cod_entidade')
+ .field('escola.cod_entidade', 'id')
.field('escola.ano_censo', 'year')
- .field('escola.fk_estado_id')
- .field('escola.fk_municipio_id');
+ .field('escola.fk_estado_id', 'state_id')
+ .field('escola.fk_municipio_id', 'city_id');
next();
}, query, response('school'));
diff --git a/src/libs/routes/state.js b/src/libs/routes/state.js
index 0a706a38..4da63260 100644
--- a/src/libs/routes/state.js
+++ b/src/libs/routes/state.js
@@ -60,13 +60,13 @@ rqf.addField({
stateApp.get('/', rqf.parse(), rqf.build(), (req, res, next) => {
req.sql.from('estado')
- .field('pk_estado_id')
+ .field('pk_estado_id', 'id')
.group('pk_estado_id')
- .field('fk_regiao_id')
+ .field('fk_regiao_id', 'region_id')
.group('fk_regiao_id')
- .field('estado.nome')
+ .field('estado.nome', 'name')
.group('estado.nome')
- .field('estado.sigla')
+ .field('estado.sigla', 'abbreviation')
.group('estado.sigla');
next();
}, query, response('state'));
diff --git a/src/test/city.js b/src/test/city.js
index 904fb2f7..1ea61a62 100644
--- a/src/test/city.js
+++ b/src/test/city.js
@@ -34,8 +34,8 @@ describe('request cities', () => {
res.should.be.json;
res.body.should.have.property('result');
res.body.result.should.be.a('array');
- res.body.result[0].should.have.property('pk_municipio_id');
- res.body.result[0].should.have.property('nome');
+ res.body.result[0].should.have.property('id');
+ res.body.result[0].should.have.property('name');
done();
});
});
@@ -48,8 +48,8 @@ describe('request cities', () => {
res.should.be.json;
res.body.should.have.property('result');
res.body.result.should.be.a('array');
- res.body.result[0].should.have.property('pk_municipio_id');
- res.body.result[0].should.have.property('nome');
+ res.body.result[0].should.have.property('id');
+ res.body.result[0].should.have.property('name');
done();
});
});
@@ -62,8 +62,8 @@ describe('request cities', () => {
res.should.be.json;
res.body.should.have.property('result');
res.body.result.should.be.a('array');
- res.body.result[0].should.have.property('pk_municipio_id');
- res.body.result[0].should.have.property('nome');
+ res.body.result[0].should.have.property('id');
+ res.body.result[0].should.have.property('name');
done();
})
})
@@ -76,8 +76,8 @@ describe('request cities', () => {
res.should.be.json;
res.body.should.have.property('result');
res.body.result.should.be.a('array');
- res.body.result[0].should.have.property('pk_municipio_id');
- res.body.result[0].should.have.property('nome');
+ res.body.result[0].should.have.property('id');
+ res.body.result[0].should.have.property('name');
done();
});
});
diff --git a/src/test/enrollment.js b/src/test/enrollment.js
index 9d76718b..6d4c35b2 100644
--- a/src/test/enrollment.js
+++ b/src/test/enrollment.js
@@ -46,7 +46,7 @@ describe('request enrollments', () => {
res.should.be.json;
res.body.should.have.property('result');
res.body.result.should.be.a('array');
- res.body.result[0].should.have.property('location_id');
+ res.body.result[0].should.have.property('id');
res.body.result[0].should.have.property('description');
done();
});
diff --git a/src/test/region.js b/src/test/region.js
index 13e8316d..daf45685 100644
--- a/src/test/region.js
+++ b/src/test/region.js
@@ -33,8 +33,8 @@ describe('request regions', () => {
res.should.be.json;
res.body.should.have.property('result');
res.body.result.should.be.a('array');
- res.body.result[0].should.have.property('pk_regiao_id');
- res.body.result[0].should.have.property('nome');
+ res.body.result[0].should.have.property('id');
+ res.body.result[0].should.have.property('name');
done();
});
});
@@ -48,8 +48,8 @@ describe('request regions', () => {
res.body.should.have.property('result');
res.body.result.should.be.a('array');
res.body.result.should.have.length(1);
- res.body.result[0].should.have.property('pk_regiao_id');
- res.body.result[0].should.have.property('nome');
+ res.body.result[0].should.have.property('id');
+ res.body.result[0].should.have.property('name');
done();
});
});
@@ -63,8 +63,8 @@ describe('request regions', () => {
res.body.should.have.property('result');
res.body.result.should.be.a('array');
res.body.result.should.have.length(1);
- res.body.result[0].should.have.property('pk_regiao_id');
- res.body.result[0].should.have.property('nome');
+ res.body.result[0].should.have.property('id');
+ res.body.result[0].should.have.property('name');
done();
});
});
diff --git a/src/test/school.js b/src/test/school.js
index 43171e30..7684e273 100644
--- a/src/test/school.js
+++ b/src/test/school.js
@@ -33,7 +33,7 @@ describe('request schools', () => {
res.should.be.json;
res.body.should.have.property('result');
res.body.result.should.be.a('array');
- res.body.result[0].should.have.property('cod_entidade');
+ res.body.result[0].should.have.property('id');
res.body.result[0].should.have.property('year');
//res.body.result[0].should.have.property('nome_entidade');
done();
@@ -48,7 +48,7 @@ describe('request schools', () => {
res.should.be.json;
res.body.should.have.property('result');
res.body.result.should.be.a('array');
- res.body.result[0].should.have.property('cod_entidade');
+ res.body.result[0].should.have.property('id');
res.body.result[0].should.have.property('year');
//res.body.result[0].should.have.property('nome_entidade');
done();
@@ -63,7 +63,7 @@ describe('request schools', () => {
res.should.be.json;
res.body.should.have.property('result');
res.body.result.should.be.a('array');
- res.body.result[0].should.have.property('cod_entidade');
+ res.body.result[0].should.have.property('id');
res.body.result[0].should.have.property('year');
//res.body.result[0].should.have.property('nome_entidade');
done();
diff --git a/src/test/state.js b/src/test/state.js
index c1b08f92..df45900d 100644
--- a/src/test/state.js
+++ b/src/test/state.js
@@ -34,9 +34,9 @@ describe('request states', () => {
res.should.be.json;
res.body.should.have.property('result');
res.body.result.should.be.a('array');
- res.body.result[0].should.have.property('pk_estado_id');
- res.body.result[0].should.have.property('fk_regiao_id');
- res.body.result[0].should.have.property('nome');
+ res.body.result[0].should.have.property('id');
+ res.body.result[0].should.have.property('region_id');
+ res.body.result[0].should.have.property('name');
done();
});
});
@@ -50,9 +50,9 @@ describe('request states', () => {
res.body.should.have.property('result');
res.body.result.should.be.a('array');
res.body.result.should.have.length(1);
- res.body.result[0].should.have.property('pk_estado_id');
- res.body.result[0].should.have.property('fk_regiao_id');
- res.body.result[0].should.have.property('nome');
+ res.body.result[0].should.have.property('id');
+ res.body.result[0].should.have.property('region_id');
+ res.body.result[0].should.have.property('name');
done();
});
});
@@ -65,9 +65,9 @@ describe('request states', () => {
res.should.be.json;
res.body.should.have.property('result');
res.body.result.should.be.a('array');
- res.body.result[0].should.have.property('pk_estado_id');
- res.body.result[0].should.have.property('fk_regiao_id');
- res.body.result[0].should.have.property('nome');
+ res.body.result[0].should.have.property('id');
+ res.body.result[0].should.have.property('region_id');
+ res.body.result[0].should.have.property('name');
done();
});
});
@@ -81,9 +81,9 @@ describe('request states', () => {
res.body.should.have.property('result');
res.body.result.should.be.a('array');
res.body.result.should.have.length(1);
- res.body.result[0].should.have.property('pk_estado_id');
- res.body.result[0].should.have.property('fk_regiao_id');
- res.body.result[0].should.have.property('nome');
+ res.body.result[0].should.have.property('id');
+ res.body.result[0].should.have.property('region_id');
+ res.body.result[0].should.have.property('name');
done();
});
});
--
GitLab