Merge branch 'issue/506' into 'develop'

SCRUM#506: Add shell linter

See merge request !15

.build.sh

@@ -6,13 +6,13 @@ apt-get update && apt-get install -y devscripts
 
 CHANGELOG="package/debian/changelog"
 LINE=$(head -n 1 $CHANGELOG)
-PACKAGE=$(echo $LINE | cut -d' ' -f1)
-VERSION=$(echo $LINE | cut -d' ' -f2 | grep -o -E '[0-9]*\.[0-9]*\.[0-9]*')
-tar --exclude=debian -czf ${PACKAGE}_${VERSION}.orig.tar.gz package/*
+PACKAGE=$(echo "$LINE" | cut -d' ' -f1)
+VERSION=$(echo "$LINE" | cut -d' ' -f2 | grep -o -E '[0-9]*\.[0-9]*\.[0-9]*')
+tar --exclude=debian -czf "${PACKAGE}"_"${VERSION}".orig.tar.gz package/*
 
-cd package
+cd package || exit -1
 debuild -us -uc
-cd ../
+cd ../ || exit -1
 
 mkdir build/
-mv ${PACKAGE}* build/
+mv "${PACKAGE}"* build/

.deploy.sh

@@ -5,7 +5,7 @@
 
 apt-get update && apt-get install -y dput ssh
 
-eval $(ssh-agent -s)
+eval "$(ssh-agent -s)"
 ssh-add <(echo "$PRIV_KEY")
 
 echo "Deploy job name: $CI_JOB_NAME"
@@ -15,9 +15,10 @@ if [ "$CI_JOB_NAME" = "deploy_for_testing" ]; then
 elif [ "$CI_JOB_NAME" = "deploy_for_stable" ]; then
     CHANGELOG="package/debian/changelog"
     LINE=$(head -n 1 $CHANGELOG)
-    PACKAGE=$(echo $LINE | cut -d' ' -f1)
-    VERSION=$(echo $LINE | cut -d' ' -f2 | grep -o -E '[0-9]*\.[0-9]*\.[0-9]*')
+    PACKAGE=$(echo "$LINE" | cut -d' ' -f1)
+    VERSION=$(echo "$LINE" | cut -d' ' -f2 | grep -o -E '[0-9]*\.[0-9]*\.[0-9]*')
 
     REPREPRO_CMD="reprepro -Vb /home/repository/www/le6 copysrc stable testing $PACKAGE $VERSION"
+    # shellcheck disable=SC2029
     ssh -o StrictHostKeyChecking=no -i ~/.ssh/id_rsa repository@repo.c3sl.ufpr.br "$REPREPRO_CMD"
 fi  

.gitlab-ci.yml

 ## Template para empacotamento utilizando o Gitlab-ci.
 stages:
+    - lint
     - build
     - test
     - deploy
 
+lint_shell:
+  stage: lint
+  tags:
+    - debian-packaging
+  script:
+    - ./.linter_shell.sh
+
 build:
   stage: build
   artifacts:

.linter_shell.sh

+#!/bin/bash
+YELLOW='\033[0;33m'
+BLUE='\033[0;34m'
+NC='\033[0m' # No Color
+
+sh_files=$(find -name "*.sh")
+exe_files=$(grep -Erl "#\!/bin/(bash|sh)" --exclude=*.* package)
+files="$sh_files\n$exe_files"
+#find no files
+if [[ "$files" == "\n" ]];then
+  echo -e "${YELLOW}No shell files found!${NC}"
+  exit 0
+fi
+
+echo  -e "$files"| xargs shellcheck -s bash
+if [[ $? -eq 0 ]];then
+  echo "AWESOME!No problems found."
+  exit 0
+else
+  echo -e "Understand errors in: ${BLUE}https://github.com/koalaman/shellcheck/wiki${NC}"
+  exit 1
+fi
+